linux-kernel - Re: [lkp] [ipc/sem.c] 99ac0dfffc: aim9.shared_memory.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d29a454-9acf-f711-039f-c193032275be@colorfullife.com>
Date:   Tue, 6 Sep 2016 14:03:57 +0200
From:   Manfred Spraul <manfred@...orfullife.com>
To:     kernel test robot <xiaolong.ye@...el.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...org
Subject: Re: [lkp] [ipc/sem.c] 99ac0dfffc: aim9.shared_memory.ops_per_sec
 -8.9% regression

Hi,

On 09/06/2016 08:42 AM, kernel test robot wrote:
> FYI, we noticed a -8.9% regression of aim9.shared_memory.ops_per_sec due to commit:
>
> commit 99ac0dfffcfb34326a880e90e06c30a2a882c692 ("ipc/sem.c: fix complex_count vs. simple op race")
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>
> in testcase: aim9
> on test machine: 4 threads Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz with 4G memory
> with following parameters:
>
>
> commit:
>    5ae37d6d64 ("config/android: Remove CONFIG_IPV6_PRIVACY")
>    99ac0dfffc ("ipc/sem.c: fix complex_count vs. simple op race")
>
> 5ae37d6d64c605ee 99ac0dfffcfb34326a880e90e0
> ---------------- --------------------------
>         fail:runs  %reproduction    fail:runs
>             |             |             |
>           %stddev     %change         %stddev
>               \          |                \
>     1398301 ±  1%      -8.9%    1274143 ±  0%  aim9.shared_memory.ops_per_sec
The shared memory test uses sem_op for token passing.

I think the root cause is the additional smp_mb() after spin_lock(), at 
least I got +8.9% when I removed the barrier.

#./sem_scalebench -t 30 -c 1 -p 1 -i 1 -h 4 -m 0 -d 1 -o 1 -f

(Note: Just removing the barrier is not an option)

--
     Manfred

View attachment "patch-ipc-no-smp_mb" of type "text/plain" (547 bytes)