linux-kernel - Re: [PATCH] usb: xhci-plat: Add generic PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57CECAB8.6060402@linux.intel.com>
Date:   Tue, 6 Sep 2016 16:55:04 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Srinath Mannam <srinath.mannam@...adcom.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Cc:     BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Scott Branden <scott.branden@...adcom.com>,
        Ray Jui <ray.jui@...adcom.com>
Subject: Re: [PATCH] usb: xhci-plat: Add generic PHY support

On 29.08.2016 10:26, Srinath Mannam wrote:
> Hi Mathias Nyman,
>
> Could you please provide your inputs on this?
> If you find it in good condition, please consider it for the next release.
>

I'm not that involved in the usb phy or generic phy, but to me it looks like
we should let usb core handle this and not duplicate any more of the phy code to
xhci-plat.c

usb_add_hcd() in hcd.c already takes care of both usb phy and generic phy cases,

I'd like to remove the phy code from xhci-plat.c if possible, but haven't
looked into if there are some parts that must be done in xhci-plat.c still.

-Mathias