linux-kernel - Re: [PATCH] drm: squash lines for simple wrapper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATEk47A9BMd=DVAGynzpcAz-sTqSed4XQnwGrkJ8XZmXQ@mail.gmail.com>
Date:   Thu, 8 Sep 2016 00:09:24 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
        Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
        Yakir Yang <ykk@...k-chips.com>, Huang Rui <ray.huang@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Monk Liu <Monk.Liu@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Eric Huang <JinHuiEric.Huang@....com>,
        Flora Cui <Flora.Cui@....com>, Inki Dae <inki.dae@...sung.com>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        Dave Airlie <airlied@...hat.com>,
        intel-gfx@...ts.freedesktop.org,
        Frediano Ziglio <fziglio@...hat.com>,
        Samuel Li <samuel.li@....com>,
        Christian König <christian.koenig@....com>,
        Tomasz Figa <tomasz.figa@...omium.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tom St Denis <tom.stdenis@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] drm: squash lines for simple wrapper functions

Hi Jani,


2016-09-07 17:34 GMT+09:00 Jani Nikula <jani.nikula@...ux.intel.com>:
> On Wed, 07 Sep 2016, Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
>> Remove unneeded variables and assignments.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> ...
>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 95ddd56..59d029d 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1361,13 +1361,7 @@ void i915_driver_unload(struct drm_device *dev)
>>
>>  static int i915_driver_open(struct drm_device *dev, struct drm_file *file)
>>  {
>> -     int ret;
>> -
>> -     ret = i915_gem_open(dev, file);
>> -     if (ret)
>> -             return ret;
>> -
>> -     return 0;
>> +     return i915_gem_open(dev, file);
>>  }
>
> Seems to me the whole function could be replaced by a direct use of
> i915_gem_open().

Good catch.


Shall I send v2?

Or, should it be done in a separate follow-up patch?
(I hope you can do it in this case.)



-- 
Best Regards
Masahiro Yamada