linux-kernel - Re: [sched/wait] 02ae2b22bd: WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160908120300.GA11135@redhat.com>
Date:   Thu, 8 Sep 2016 14:03:00 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     kernel test robot <xiaolong.ye@...el.com>
Cc:     lkp@...org, linux-kernel@...r.kernel.org,
        Neil Brown <neilb@...e.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Bart Van Assche <bvanassche@....org>,
        Al Viro <viro@...IV.linux.org.uk>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [sched/wait]  02ae2b22bd: WARNING: CPU: 0 PID: 958 at
 kernel/sched/core.c:7610 __might_sleep+0x6e/0x90

On 09/08, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> https://github.com/0day-ci/linux Oleg-Nesterov/sched-wait-fix-and-then-kill-abort_exclusive_wait/20160907-145024
> commit 02ae2b22bd2a42c4e4054563b139a541ba67a43e ("sched/wait: avoid abort_exclusive_wait() in ___wait_event()")

Thanks!


> [   30.775242] kill 958 cat /proc/kmsg
> [   30.775242] wait for background monitors: 959 962 oom-killer nfs-hang
> [   32.078512] ------------[ cut here ]------------
> [   32.080657] WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might_sleep+0x6e/0x90
> [   32.084787] do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81107e0d>] prepare_to_wait_event+0xad/0x120

Because I am stupid. With my change prepare_to_wait_event() does
set_current_state(state) even on failure.

Thanks a lot, I'll send V2.

Oleg.