linux-kernel - Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f05c488-1889-057b-7068-8e070ff95611@codethink.co.uk>
Date:   Thu, 8 Sep 2016 14:21:04 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Andreas Färber <afaerber@...e.de>,
        Neil Armstrong <narmstrong@...libre.com>
Cc:     devicetree <devicetree@...r.kernel.org>, khilman@...libre.com,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        broonie@...nel.org, carlo@...one.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

On 08/09/16 13:50, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
>> Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
>>> This patchset adds a specific compatible string in the Meson SPIFC driver for
>>> the Amlogic Meson GXBB SoC.
>>
>> Any particular reason? We could just reuse the meson6 one since there
>> appear to be no code changes so far.
>
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
>
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

I prefer to add both the device-tree itself, so if there are differences
found later then it can be dealt with without rebuilding both the DT
and kernel.

It is nice to have the new ones added to the driver so that you know the
hardware choices in play.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius