lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Sep 2016 18:59:24 +0100 (BST) From: James Simmons <jsimmons@...radead.org> To: Baoyou Xie <baoyou.xie@...aro.org> cc: oleg.drokin@...el.com, andreas.dilger@...el.com, gregkh@...uxfoundation.org, bobijam.xu@...el.com, jinshan.xiong@...el.com, lai.siyao@...el.com, mike.rapoport@...il.com, amitoj1606@...il.com, devel@...verdev.osuosl.org, arnd@...db.de, xie.baoyou@....com.cn, linux-kernel@...r.kernel.org, lustre-devel@...ts.lustre.org Subject: Re: [PATCH] staging/lustre/lov: add missing header dependencies > We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes] > > In fact, these functions are declared in ../llite/vvp_internal.h, > so this patch add missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org> Nak. The header vvp_internal.h is meant to private to the llite layer. Looking at the coming patch updates I see lov_lsm_[put|get] will not be used in the lov later. Now lov_read_and_clear_async is still used in both layers. The header used for this case is cl_object.h. Might rename that function to be consistent with the rest of the header. I will look into a cleanup for this. > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c > index f9621b0..912c416 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_object.c > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c > @@ -38,6 +38,7 @@ > #define DEBUG_SUBSYSTEM S_LOV > > #include "lov_cl_internal.h" > +#include "../llite/vvp_internal.h" > > /** \addtogroup lov > * @{ > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@...uxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >
Powered by blists - more mailing lists