linux-kernel - Re: [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2016 19:23:44 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
cc:     oleg.drokin@...el.com, andreas.dilger@...el.com,
        gregkh@...uxfoundation.org, bobijam.xu@...el.com,
        jinshan.xiong@...el.com, lai.siyao@...el.com,
        mike.rapoport@...il.com, amitoj1606@...il.com,
        devel@...verdev.osuosl.org, arnd@...db.de, xie.baoyou@....com.cn,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Developement <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH] staging/lustre/lov: add missing header
 dependencies


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Nak. I have a patch coming soon from our server code branch that removes 
lov_lsm_get() and makes lov_lsm_put used only in the lov layer.
The patch is ready but I need to test it first.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@...ts.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>