linux-kernel - Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2d1kenu2g.fsf@baylibre.com>
Date:   Thu, 08 Sep 2016 11:08:07 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Carlo Caione <carlo@...one.org>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins

Jerome Brunet <jbrunet@...libre.com> writes:

> Add EE domains pins for the SPI flash controller
>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..802ad83 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -156,6 +156,11 @@ static const unsigned int emmc_clk_pins[] = { PIN(BOOT_8, EE_OFF) };
>  static const unsigned int emmc_cmd_pins[] = { PIN(BOOT_10, EE_OFF) };
>  static const unsigned int emmc_ds_pins[] = { PIN(BOOT_15, EE_OFF) };
>  
> +static const unsigned int spifc_d_pins[]	= { PIN(BOOT_11, EE_OFF) };
> +static const unsigned int spifc_q_pins[]	= { PIN(BOOT_12, EE_OFF) };
> +static const unsigned int spifc_c_pins[]	= { PIN(BOOT_13, EE_OFF) };
> +static const unsigned int spifc_cs_pins[]	= { PIN(BOOT_15, EE_OFF) };

In the datasheet, these are called nor_* instead of spifc_*.  I'm trying
to keep the names here aligned with the names in the datasheet.  Please
rename to nor_*.

Thanks,

Kevin