linux-kernel - [PATCH] gpio: gpiolib: fix an incorrect use of WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  9 Sep 2016 11:19:29 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Vignesh R <vigneshr@...com>, Yong Li <yong.b.li@...el.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON()

This breaks the build due to the format string being passed as
argument. Fix it by using WARN().

Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
---
NOTE This patch applies on top of linux-gpio devel branch.

 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 95effec..384ed0a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1618,8 +1618,8 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,
 	 * used to configure the interrupts, as you may end-up with
 	 * conflicting triggers. Tell the user, and reset to NONE.
 	 */
-	if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
-		    "%s: Ignoring %d default trigger\n", of_node->full_name))
+	if (WARN(of_node && type != IRQ_TYPE_NONE,
+		 "%s: Ignoring default trigger\n", of_node->full_name))
 		type = IRQ_TYPE_NONE;
 
 	gpiochip->irqchip = irqchip;
-- 
2.7.4