linux-kernel - Re: [PATCH] gpio: gpiolib: fix an incorrect use of WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZiquBt6mSuT7rhTc3W5BC7KUA7g=ZOD3cynGZW86LDNA@mail.gmail.com>
Date:   Mon, 12 Sep 2016 14:51:06 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Vignesh R <vigneshr@...com>, Yong Li <yong.b.li@...el.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON()

On Fri, Sep 9, 2016 at 11:19 AM, Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:

> This breaks the build due to the format string being passed as
> argument. Fix it by using WARN().
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
> NOTE This patch applies on top of linux-gpio devel branch.

Thanks, Marc realized the mistake and sent a v2 patch so I
have already fixed this up, sorry for leaving the tree in a mess
over the weekend.

Yours,
Linus Walleij