linux-kernel - Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d836fe83-8daa-9e17-4eca-41331c480a24@roeck-us.net>
Date:   Mon, 12 Sep 2016 06:01:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Matt Redfearn <matt.redfearn@...tec.com>,
        Wim Van Sebroeck <wim@...ana.be>
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

On 09/12/2016 02:35 AM, Matt Redfearn wrote:
> Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from
> struct watchdog_device") removed the dev pointer from struct
> watchdog_device, but this driver was still assigning it, leading to a
> compilation error:
>
> drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’:
> drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’
> has no member named ‘dev’
>   rt288x_wdt_dev.dev = &pdev->dev;
>                 ^
> scripts/Makefile.build:289: recipe for target
> 'drivers/watchdog/rt2880_wdt.o' failed
>
> Fix this by removing the assignment.
>
> Fixes: 0254e953537c

Fixes: 0254e953537c ("watchdog: Drop pointer to watchdog device ...")

> Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>

Cc: stable@...r.kernel.org # v4.5+

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>
>  drivers/watchdog/rt2880_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 1967919ae743..14b4fd428fff 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -158,7 +158,6 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
>
>  	rt288x_wdt_freq = clk_get_rate(rt288x_wdt_clk) / RALINK_WDT_PRESCALE;
>
> -	rt288x_wdt_dev.dev = &pdev->dev;
>  	rt288x_wdt_dev.bootstatus = rt288x_wdt_bootcause();
>  	rt288x_wdt_dev.max_timeout = (0xfffful / rt288x_wdt_freq);
>  	rt288x_wdt_dev.parent = &pdev->dev;
>