linux-kernel - Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161008140348.GC23290@spo001.leaseweb.nl>
Date:   Sat, 8 Oct 2016 16:03:48 +0200
From:   Wim Van Sebroeck <wim@...ana.be>
To:     Matt Redfearn <matt.redfearn@...tec.com>
Cc:     linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

Hi Matt,

> Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from
> struct watchdog_device") removed the dev pointer from struct
> watchdog_device, but this driver was still assigning it, leading to a
> compilation error:
> 
> drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’:
> drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’
> has no member named ‘dev’
>   rt288x_wdt_dev.dev = &pdev->dev;
>                 ^
> scripts/Makefile.build:289: recipe for target
> 'drivers/watchdog/rt2880_wdt.o' failed
> 
> Fix this by removing the assignment.
> 
> Fixes: 0254e953537c
> Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>
> ---

This patch and a similar patch from Guenter regarding mt7621_wdt was
added to linux-watchdog-next almost 2 weeks ago.

Kind regards,
Wim.