linux-kernel - Re: [PATCH] net: r6040: add in missing white space in error message text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 16:04:01 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: r6040: add in missing white space in error message
 text

Hello.

On 9/12/2016 3:08 PM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> A couple of dev_err messages span two lines and the literal
> string is missing a white space between words. Add the white
> space.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/rdc/r6040.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index cb29ee2..5dc655b 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	/* this should always be supported */
>  	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
>  	if (err) {
> -		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> +		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
>  				"not supported by the card\n");
>  		goto err_out_disable_dev;
>  	}
>  	err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
>  	if (err) {
> -		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> +		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
>  				"not supported by the card\n");
>  		goto err_out_disable_dev;
>  	}

    The message strings simply shouldn't be broken up, and checkpatch.pl knows 
about that.

MBR, Sergei