linux-kernel - Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db1758f8-0335-6661-e797-b2021682a087@arm.com>
Date:   Mon, 12 Sep 2016 14:06:09 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Colin King <colin.king@...onical.com>,
        Russell King <linux@...linux.org.uk>,
        Vineet Gupta <vgupta@...opsys.com>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Joerg Roedel <jroedel@...e.de>,
        Jesper Nilsson <jesper.nilsson@...s.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dma-mapping: add in missing white space in error
 message text

On 12/09/16 13:52, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/arm/common/dmabounce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..f47767b 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>  
>  	if (!device_info) {
>  		dev_warn(dev,
> -			 "Never registered with dmabounce but attempting"
> +			 "Never registered with dmabounce but attempting "
>  			 "to unregister!\n");

Per Documentation/CodingStyle, better to put the whole thing onto one
line so that, say, "git grep 'attempting to unregister'" doesn't leave
one scratching ones head in confusion.

Of course, even better would be to get rid of the whole thing and
convert ARM to use SWIOTLB, but hey, one thing at a time ;)

Robin.

>  		return;
>  	}
>