linux-kernel - Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <747e1ae3-80cf-dfa7-613a-c3f8821ad2af@st.com>
Date:   Mon, 12 Sep 2016 18:47:40 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        <linux-kernel@...r.kernel.org>
CC:     <netdev@...r.kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>
Subject: Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for
 built-in or module

Hi Javier,

On 09/12/2016 04:03 PM, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Using the macro makes the code more readable by helping abstract away some
> of the Kconfig built-in and module enable details.
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
>
>  drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
> index 2533b91f1421..d3292c4a6eda 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/common.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
> @@ -30,7 +30,7 @@
>  #include <linux/stmmac.h>
>  #include <linux/phy.h>
>  #include <linux/module.h>
> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> +#if IS_ENABLED(CONFIG_VLAN_8021Q)
>  #define STMMAC_VLAN_TAG_USED
>  #include <linux/if_vlan.h>
>  #endif
>

Reviewed-by: Alexandre TORGUE <alexandre.torgue@...com>

Thanks,

Alex