linux-kernel - Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57D7D4C1.6080007@arm.com>
Date:   Tue, 13 Sep 2016 11:28:17 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>
Cc:     Nicolas Ferre <nicolas.ferre@...el.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-kernel@...r.kernel.org, stable@...nel.vger.org
Subject: Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

On 13/09/16 11:10, Boris Brezillon wrote:
> aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip
> lock without disabling interrupts, which can lead to a deadlock if an
> interrupt occurs while the lock is held in one of these functions.
> 
> Replace irq_gc_{lock,unlock}() calls by
> raw_spin_{lock_irqsave,unlock_irqrestore}() ones to prevent this bug from
> happening.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
> Cc: <stable@...nel.vger.org>
> ---
>  drivers/irqchip/irq-atmel-aic.c  | 5 +++--
>  drivers/irqchip/irq-atmel-aic5.c | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)

Acked-by: Marc Zyngier <marc.zyngier@....com>

Thomas, any chance you could queue this one as a fix for 4.8-rc7?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...