linux-kernel - Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYFSRjo7ncqOv87_r0Ms1moVxXZTOGwWoq-YCqtDh5WNA@mail.gmail.com>
Date:   Tue, 13 Sep 2016 13:49:25 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Phil Reid <preid@...ctromag.com.au>
Cc:     Colin King <colin.king@...onical.com>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

On Tue, Sep 13, 2016 at 6:04 AM, Phil Reid <preid@...ctromag.com.au> wrote:
> On 12/09/2016 21:40, Linus Walleij wrote:
>>
>> On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@...onical.com>
>> wrote:
>>
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> ret is not initialized so it contains garbage.  Ensure garbage
>>> is not returned in the case that pdata && pdata->teardown is false
>>> by initializing ret to 0.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>
>>
>> Patch applied.
>
> G'day Linus,
>
>
> I believe this does the same as Arnd Bergmanns patch from 26 Aug.
> [PATCH 1/5] gpio: pca954x: fix undefined error code from remove
>
> IMO Colin's is the cleaner solution.
> Arnd's could be removed.

OK you're right. I reverted Arnd's patch.

Yours,
Linus Walleij