linux-kernel - Re: [PATCH] driver: base: pinctrl: return error from pinctrl_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 13:59:51 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Deepak <deepak_das@...tor.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        vzapolsk <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH] driver: base: pinctrl: return error from pinctrl_bind_pins()

On Tue, Sep 13, 2016 at 9:13 AM, Deepak <deepak_das@...tor.com> wrote:

> strict pin controller returns -EINVAL in case of pin request which
> is already claimed by somebody else.
> Following is the sequence of calling pin_request() from
> pinctrl_bind_pins():-
> pinctrl_bind_pins()->pinctrl_select_state()->pinmux_enable_setting()->
> pin_request()
>
> But pinctrl_bind_pins() only returns -EPROBE_DEFER which makes device
> driver probe successful even if the pin request is rejected by the pin
> controller subsystem.
>
> This commit modifies pinctrl_bind_pins() to return error if the pin is
> rejected by pin control subsystem.
>
> Signed-off-by: Deepak Das <deepak_das@...tor.com>

Aha

>      /* Only return deferrals */
> -    if (ret != -EPROBE_DEFER)
> +    if ((ret != -EPROBE_DEFER) && (ret != -EINVAL))
>          ret = 0;

I rewrote this when applying, like this:

-       /* Only return deferrals */
-       if (ret != -EPROBE_DEFER)
-               ret = 0;
+       /* Return deferrals */
+       if (ret == -EPROBE_DEFER)
+               return ret;
+       if (ret == -EINVAL) {
+               dev_err(dev, "could not initialize pin control state\n");
+               return ret;
+       }
+       /* We ignore errors like -ENOENT meaning no pinctrl state */

-       return ret;
+       return 0;

Can you confim that this works for you too?

Yours,
Linus Walleij