linux-kernel - Re: [PATCH] tracing/syscalls: add in missing white space in error message text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160913183551.GA32416@gmail.com>
Date:   Tue, 13 Sep 2016 20:35:51 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Colin King <colin.king@...onical.com>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        trivial@...nel.org
Subject: Re: [PATCH] tracing/syscalls: add in missing white space in error
 message text


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 12 Sep 2016 12:41:27 +0100
> Colin King <colin.king@...onical.com> wrote:
> 
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > pr_info message spans two lines and the literal string is missing
> > a white space between words. Add the white space.
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  kernel/trace/trace_syscalls.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index b2b6efc..79d8752 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -610,7 +610,7 @@ static int perf_sysenter_enable(struct trace_event_call *call)
> >  	if (!sys_perf_refcount_enter)
> >  		ret = register_trace_sys_enter(perf_syscall_enter, NULL);
> >  	if (ret) {
> > -		pr_info("event trace: Could not activate"
> > +		pr_info("event trace: Could not activate "
> >  				"syscall entry trace point");
> 
> Actually, the better fix is to make this one line. The 80 character
> limit is not applicable when it cuts strings in half, especially when
> it causes bugs like this.
> 
> Also, this should go through trivial (with an ack from us).

Agreed that user visible strings should be on a single line. With that change:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo