linux-kernel - Re: [PATCH] xen: consolidate swiotbl_xen dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913183726.GB32416@gmail.com>
Date:   Tue, 13 Sep 2016 20:37:27 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     sstabellini@...nel.org, konrad.wilk@...cle.com,
        boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
        jgross@...e.com, x86@...nel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] xen: consolidate swiotbl_xen dma_ops


* Christoph Hellwig <hch@....de> wrote:

> On Mon, Sep 12, 2016 at 01:45:40PM +0200, Ingo Molnar wrote:
> > Please organize such initializers better! Something like this:
> 
> > Makes it much easier to review such definitions.
> 
> That's my personal preference, too.  But this is just moving/consolidating
> code, so I don't plan to do fancy moves.

I can be passive-aggressive too, so:

  NAKed-by: Ingo Molnar <mingo@...nel.org>

If the ugliness that makes the patch much harder to review than it should be is 
fixed in the same patch or in a different patch then:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo