linux-kernel - Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYSr-4wbsupAPa6Q1nd6THf9YS4TMYa5OqMzF6GNOBMxg@mail.gmail.com>
Date:   Wed, 14 Sep 2016 11:06:08 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Subject: Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data

On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@...ck-us.net> wrote:

> irq_get_irq_data() can return NULL, which results in a nasty crash.
> Check its return value before passing it on to irqd_set_trigger_type().
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Should probably be tagged for stable.

Yours,
Linus Walleij