linux-kernel - Re: [PATCH] clk: versatile: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2862092.ohvOYo10Tb@wuerfel>
Date:   Wed, 14 Sep 2016 11:08:28 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] clk: versatile: add missing header dependencies

On Wednesday, September 14, 2016 11:04:29 AM CEST Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@...db.de> wrote:
> > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
> >> We get 1 warning when building kernel with W=1:
> >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> >>
> >> In fact, this function is declared in clk-realview.h,
> >> so this patch add missing header dependencies.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> >>
> >
> > Please leave this one for now. We are in the process of removing the
> > last caller of this function, and should just remove the header file
> > and the function definition in the next release.
> 
> +1 on this, leave it. I can clean it up for v4.10 or even
> for an -rc if you want it real neat in v4.9.
> 

I think v4.10 is fine: Baoyou has done a great job so far fixing a lot
of those warnings, but we already know that there will be a lot remaining
after v4.9, so v4.10 is the earliest possible version in which we
can turn on the warning by default.

	Arnd