linux-kernel - Re: [PATCH 03/15] hisi_sas: keep CHL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5885219f-71c7-418d-f502-57022aaa1587@suse.de>
Date:   Wed, 14 Sep 2016 13:48:03 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/15] hisi_sas: keep CHL_INT2 masked for v2 HW

On 09/06/2016 05:36 PM, John Garry wrote:
> None of the CHL_INT2 interrupts are serviced
> in the channel irq ISR, so leave the interrupt
> source masked.
> The interrupt mask is initially set in
> init_reg_v2_hw().
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index e0c124b..25e7c58 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -965,14 +965,8 @@ static void start_phys_v2_hw(unsigned long data)
>  
>  static void phys_init_v2_hw(struct hisi_hba *hisi_hba)
>  {
> -	int i;
>  	struct timer_list *timer = &hisi_hba->timer;
>  
> -	for (i = 0; i < hisi_hba->n_phy; i++) {
> -		hisi_sas_phy_write32(hisi_hba, i, CHL_INT2_MSK, 0x6a);
> -		hisi_sas_phy_read32(hisi_hba, i, CHL_INT2_MSK);
> -	}
> -
>  	setup_timer(timer, start_phys_v2_hw, (unsigned long)hisi_hba);
>  	mod_timer(timer, jiffies + HZ);
>  }
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)