linux-kernel - Re: [PATCH v6] genirq: Machine-parsable version of /proc/interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 15:36:59 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Craig Gallek <kraigatgoog@...il.com>
cc:     David Decotigny <decot@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] genirq: Machine-parsable version of
 /proc/interrupts

On Tue, 13 Sep 2016, Craig Gallek wrote:
> +What:		/sys/kernel/irq/<irq>/name
> +Date:		September 2016
> +KernelVersion:	4.9
> +Contact:	Craig Gallek <kraig@...gle.com>
> +Description:	Human-readable flow handler name as defined by the device
> +		driver.

That's ambigous. device driver reads like a the driver of the device which
uses this irq. I fixed that up.

>  static void free_desc(unsigned int irq)
>  {
>  	struct irq_desc *desc = irq_to_desc(irq);
>  
>  	unregister_irq_proc(irq, desc);
> +	kobject_del(&desc->kobj);

You forgot to move this under the sparse lock protection as well. There is
the same race against a concurrent initcall.

Thanks,

	tglx