linux-kernel - Re: [PATCH v6] genirq: Machine-parsable version of /proc/interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEfhGiwGwpW2i3nepxxvYbtpHcOEHQcj5XovUa5Usi3CQfuaSQ@mail.gmail.com>
Date:   Wed, 14 Sep 2016 09:59:20 -0400
From:   Craig Gallek <kraigatgoog@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     David Decotigny <decot@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] genirq: Machine-parsable version of /proc/interrupts

On Wed, Sep 14, 2016 at 9:36 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Tue, 13 Sep 2016, Craig Gallek wrote:
>> +What:                /sys/kernel/irq/<irq>/name
>> +Date:                September 2016
>> +KernelVersion:       4.9
>> +Contact:     Craig Gallek <kraig@...gle.com>
>> +Description: Human-readable flow handler name as defined by the device
>> +             driver.
>
> That's ambigous. device driver reads like a the driver of the device which
> uses this irq. I fixed that up.
>
>>  static void free_desc(unsigned int irq)
>>  {
>>       struct irq_desc *desc = irq_to_desc(irq);
>>
>>       unregister_irq_proc(irq, desc);
>> +     kobject_del(&desc->kobj);
>
> You forgot to move this under the sparse lock protection as well. There is
> the same race against a concurrent initcall.
Good catch, thank you for the review and accepting this code.

Craig