linux-kernel - Re: [PATCH] staging: android: ion: Make ION_OF depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO_48GEBR3h5gyPH4VrLtyepq3XPt_i_Su3TUj_f2S5T2Gyv4Q@mail.gmail.com>
Date:   Wed, 14 Sep 2016 21:55:46 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Greg-KH <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        LKML <linux-kernel@...r.kernel.org>, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

Hi Laura,

On 14 September 2016 at 21:03, Laura Abbott <labbott@...hat.com> wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
>
Thanks for the patch; looks good to me.
Please feel free to apply my
Reviewed-by: Sumit Semwal <sumit.semwal@...aro.org>

Best,
Sumit.

> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
>
> Add a dependency on OF_ADDRESS
>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> Based on next-20160914
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>
>  config ION_OF
>         bool "Devicetree support for Ion"
> -       depends on ION && OF
> +       depends on ION && OF_ADDRESS
>         help
>           Provides base support for defining Ion heaps in devicetree
>           and setting them up. Also includes functions for platforms
> --
> 2.7.4
>