linux-kernel - Re: [PATCH] staging: android: ion: Make ION_OF depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160914201700.GD14003@roeck-us.net>
Date:   Wed, 14 Sep 2016 13:17:00 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Greg-KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
        Sumit Semwal <sumit.semwal@...aro.org>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

On Wed, Sep 14, 2016 at 08:33:58AM -0700, Laura Abbott wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
> 
> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
> 
> Add a dependency on OF_ADDRESS
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Laura Abbott <labbott@...hat.com>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Based on next-20160914
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>  
>  config ION_OF
>  	bool "Devicetree support for Ion"
> -	depends on ION && OF
> +	depends on ION && OF_ADDRESS
>  	help
>  	  Provides base support for defining Ion heaps in devicetree
>  	  and setting them up. Also includes functions for platforms
> -- 
> 2.7.4
>