linux-kernel - Re: perf/x86: Use kmalloc_array() in merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
Date:   Wed, 14 Sep 2016 18:40:32 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()

>> * A multiplication for the size determination of a memory allocation
>>   indicated that an array data structure should be processed.
>>   Thus use the corresponding function "kmalloc_array".
>>
>>   This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>>   to make the corresponding size determination a bit safer according to
>>   the Linux coding style convention.
> 
> Why!?

How do you think about an information like the following from
the well-known script "checkpatch.pl"?

WARNING: Prefer kmalloc_array over kmalloc with multiply


Would you like to suggest any more constraints for this kind of
software refactoring?

Regards,
Markus