linux-kernel - Re: perf/x86: Use kmalloc_array() in merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160914170452.GD5016@twins.programming.kicks-ass.net>
Date:   Wed, 14 Sep 2016 19:04:52 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     x86@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()

On Wed, Sep 14, 2016 at 06:40:32PM +0200, SF Markus Elfring wrote:
> 
> Would you like to suggest any more constraints for this kind of
> software refactoring?

Yes, don't do it. If you're writing new code by all means, do whatever
you feel, but don't go changing code just because checkpatch.