linux-kernel - Re: perf/x86: Use kmalloc_array() in merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad27a3a5-87de-b234-fb4a-2f3ab8bbcbc2@users.sourceforge.net>
Date:   Wed, 14 Sep 2016 19:38:15 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()

>> Would you like to suggest any more constraints for this kind of
>> software refactoring?
> 
> Yes, don't do it.

I am bit surprised by this feedback.


> If you're writing new code by all means, do whatever you feel,

Could you accept related software updates then?


> but don't go changing code just because checkpatch.

Why is this not a valid reason for you?

How useful can properties that are provided by a function like
kmalloc_array() be also for software modules which you care about?


Do you find any other software improvements more worthwhile?

Regards,
Markus