linux-kernel - Re: [PATCH v3 8/9] mtd: fsl-quadspi: disable AHB buffer prefetch

Open Source and information security mailing list archives

Message-ID: <CA+EcR20qsH0bix7d8Z7pBkuksnMo5-G70TcrX60SC8NYge=+=Q@mail.gmail.com>
Date:   Wed, 14 Sep 2016 14:49:10 -0500
From:   Han Xu <xhnjupt@...il.com>
To:     Yunhui Cui <B56489@...escale.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        "han.xu@...escale.com" <han.xu@...escale.com>,
        jagannadh.teki@...il.com, Yunhui Cui <yunhui.cui@....com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Yao Yuan <yao.yuan@....com>
Subject: Re: [PATCH v3 8/9] mtd: fsl-quadspi: disable AHB buffer prefetch

On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui <B56489@...escale.com> wrote:
> From: Yunhui Cui <yunhui.cui@....com>
>
> A-009282: QuadSPI: QuadSPI data pre-fetch can result in incorrect data
> Affects: QuadSPI
> Description: With AHB buffer prefetch enabled, the QuadSPI may return
> incorrect data on the AHB
> interface. The buffer pre-fetch is enabled if the fetch size as
> configured either in the LUT or in
> the BUFxCR register is greater than 8 bytes.
> Impact: Only 64 bit read allowed.
> Workaround: Keep the read data size to 64 bits (8 Bytes), which disables
> the prefetch on the AHB buffer,
> and prevents this issue from occurring.
>
> Signed-off-by: Yunhui Cui <yunhui.cui@....com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 33 ++++++++++++++++++++++++---------
>  1 file changed, 24 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index f9a7d4b..193e81b 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -41,6 +41,8 @@
>  #define QUADSPI_QUIRK_TKT253890                (1 << 2)
>  /* Controller cannot wake up from wait mode, TKT245618 */
>  #define QUADSPI_QUIRK_TKT245618         (1 << 3)
> +/*Errata A-009282: disable the AHB buffer prefetch */
> +#define QUADSPI_QUIRK_ADASZ_8BYTE_LIMIT (1 << 4)
>  /* QSPI_AMBA_BASE is internally added by SOC design */
>  #define QUADSPI_AMBA_BASE_INTERNAL     (0x10000)
>
> @@ -270,7 +272,7 @@ static struct fsl_qspi_devtype_data ls1021a_data = {
>         .rxfifo = 128,
>         .txfifo = 64,
>         .ahb_buf_size = 1024,
> -       .driver_data = 0,
> +       .driver_data = QUADSPI_QUIRK_ADASZ_8BYTE_LIMIT,
>  };
>
>  static struct fsl_qspi_devtype_data ls2080a_data = {
> @@ -278,7 +280,8 @@ static struct fsl_qspi_devtype_data ls2080a_data = {
>         .rxfifo = 128,
>         .txfifo = 64,
>         .ahb_buf_size = 1024,
> -       .driver_data = QUADSPI_AMBA_BASE_INTERNAL,
> +       .driver_data = QUADSPI_AMBA_BASE_INTERNAL
> +                      | QUADSPI_QUIRK_ADASZ_8BYTE_LIMIT,
>  };
>
>  #define FSL_QSPI_MAX_CHIP      4
> @@ -328,6 +331,11 @@ static inline int has_added_amba_base_internal(struct fsl_qspi *q)
>         return q->devtype_data->driver_data & QUADSPI_AMBA_BASE_INTERNAL;
>  }
>
> +static inline int needs_disable_ahb_prefetch(struct fsl_qspi *q)
> +{
> +       return q->devtype_data->driver_data & QUADSPI_QUIRK_ADASZ_8BYTE_LIMIT;
> +}
> +
>  /*
>   * R/W functions for big- or little-endian registers:
>   * The qSPI controller's endian is independent of the CPU core's endian.
> @@ -757,14 +765,21 @@ static void fsl_qspi_init_abh_read(struct fsl_qspi *q)
>         qspi_writel(q, QUADSPI_BUFXCR_INVALID_MSTRID, base + QUADSPI_BUF0CR);
>         qspi_writel(q, QUADSPI_BUFXCR_INVALID_MSTRID, base + QUADSPI_BUF1CR);
>         qspi_writel(q, QUADSPI_BUFXCR_INVALID_MSTRID, base + QUADSPI_BUF2CR);
> -       /*
> -        * Set ADATSZ with the maximum AHB buffer size to improve the
> -        * read performance.
> -        */
> -       qspi_writel(q, QUADSPI_BUF3CR_ALLMST_MASK |
> -                       ((q->devtype_data->ahb_buf_size / 8)
> -                       << QUADSPI_BUF3CR_ADATSZ_SHIFT),
> +
> +       if (needs_disable_ahb_prefetch(q)) {
> +               qspi_writel(q, QUADSPI_BUF3CR_ALLMST_MASK |
> +                       (1 << QUADSPI_BUF3CR_ADATSZ_SHIFT),
>                         base + QUADSPI_BUF3CR);
> +       } else {
> +               /*
> +                * Set ADATSZ with the maximum AHB buffer size to improve the
> +                * read performance.
> +               */
> +               qspi_writel(q, QUADSPI_BUF3CR_ALLMST_MASK |
> +                               ((q->devtype_data->ahb_buf_size / 8)
> +                               << QUADSPI_BUF3CR_ADATSZ_SHIFT),
> +                               base + QUADSPI_BUF3CR);
> +       }
>
>         /* We only use the buffer3 */
>         qspi_writel(q, 0, base + QUADSPI_BUF0IND);
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@....com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/


-- 
Sincerely,

Han XU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives