linux-kernel - Re: [PATCH 0/2] PCI/AER: Remove module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160914203019.GB13189@localhost>
Date:   Wed, 14 Sep 2016 15:30:20 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org, Lance Ortiz <lance.ortiz@....com>,
        Betty Dall <betty.dall@....com>,
        Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
        Chen Gong <gong.chen@...ux.intel.com>,
        KeithBuschkeith.busch@...el.com,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        linux-kernel@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>,
        Huang Ying <ying.huang@...el.com>,
        Vijay Mohan Pandarathil <vijaymohan.pandarathil@....com>,
        Jon Derrick <jonathan.derrick@...el.com>
Subject: Re: [PATCH 0/2] PCI/AER: Remove module parameters

On Tue, Sep 06, 2016 at 05:19:22PM -0500, Bjorn Helgaas wrote:
> I'd like to remove the aerdriver.nosourceid and aerdriver.forceload kernel
> parameters.  They seem like basically debugging things that are not really
> supportable upstream.
> 
> "nosourceid" may have some legitimate uses, but I'd rather it were done via
> quirks with the flag Jon Derrick recently added so it happens
> automatically, without users having to specify the parameter.
> 
> I don't *know* of any actual users of either of these, but obviously that
> doesn't mean there are none.  Comments welcome.
> 
> ---
> 
> Bjorn Helgaas (2):
>       PCI/AER: Remove aerdriver.nosourceid kernel parameter
>       PCI/AER: Remove aerdriver.forceload kernel parameter
> 
> 
>  Documentation/PCI/pcieaer-howto.txt |   26 +++++++++-----------------
>  drivers/pci/pcie/aer/aerdrv.c       |    7 +------
>  drivers/pci/pcie/aer/aerdrv.h       |    8 --------
>  drivers/pci/pcie/aer/aerdrv_core.c  |   31 ++++---------------------------
>  4 files changed, 14 insertions(+), 58 deletions(-)

I'm going to go out on a limb a little bit and apply these to pci/aer for
v4.9.  Please let me know if you trip over any issues.