linux-kernel - RE: [PATCH 0/2] PCI/AER: Remove module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1D440B9B88E22A4ABEF89F9F1F81BC2949120D8F@FMSMSX106.amr.corp.intel.com>
Date:   Sat, 17 Sep 2016 04:49:11 +0000
From:   "Tang, CQ" <cq.tang@...el.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Lance Ortiz <lance.ortiz@....com>,
        Betty Dall <betty.dall@....com>,
        Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
        Chen Gong <gong.chen@...ux.intel.com>,
        "KeithBuschkeith.busch@...el.com" <KeithBuschkeith.busch@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Shuah Khan <shuahkh@....samsung.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        Vijay Mohan Pandarathil <vijaymohan.pandarathil@....com>,
        "Derrick, Jonathan" <jonathan.derrick@...el.com>
Subject: RE: [PATCH 0/2] PCI/AER: Remove module parameters

Bjorn,
     Can we extend this aerdriver to support AER from a root complex integrated endpoint? Root complex event collector has the same job as root port in this case.

     It looks that both port driver and aer driver check PCI_EXP_TYPE_ROOT_PORT/PCI_EXP_TYPE_UPSTREAM/PCI_EXP_TYPE_DOWNSTREAM only.
portdrv_pci.c:127, aerdrv.c:86

      Is it just a simple addition of PCI_EXP_TYPE_RC_EC to above two places?  Is there any difference to recover a root complex integrated endpoint? (compared with devices connected to root port).

Thanks.
--CQ

> -----Original Message-----
> From: linux-pci-owner@...r.kernel.org [mailto:linux-pci-
> owner@...r.kernel.org] On Behalf Of Bjorn Helgaas
> Sent: Wednesday, September 14, 2016 1:30 PM
> To: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org; Lance Ortiz <lance.ortiz@....com>; Betty Dall
> <betty.dall@....com>; Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>;
> Chen Gong <gong.chen@...ux.intel.com>; KeithBuschkeith.busch@...el.com;
> Rafael J. Wysocki <rjw@...ysocki.net>; linux-kernel@...r.kernel.org; Shuah
> Khan <shuahkh@....samsung.com>; Huang, Ying <ying.huang@...el.com>;
> Vijay Mohan Pandarathil <vijaymohan.pandarathil@....com>; Derrick,
> Jonathan <jonathan.derrick@...el.com>
> Subject: Re: [PATCH 0/2] PCI/AER: Remove module parameters
> 
> On Tue, Sep 06, 2016 at 05:19:22PM -0500, Bjorn Helgaas wrote:
> > I'd like to remove the aerdriver.nosourceid and aerdriver.forceload
> > kernel parameters.  They seem like basically debugging things that are
> > not really supportable upstream.
> >
> > "nosourceid" may have some legitimate uses, but I'd rather it were
> > done via quirks with the flag Jon Derrick recently added so it happens
> > automatically, without users having to specify the parameter.
> >
> > I don't *know* of any actual users of either of these, but obviously
> > that doesn't mean there are none.  Comments welcome.
> >
> > ---
> >
> > Bjorn Helgaas (2):
> >       PCI/AER: Remove aerdriver.nosourceid kernel parameter
> >       PCI/AER: Remove aerdriver.forceload kernel parameter
> >
> >
> >  Documentation/PCI/pcieaer-howto.txt |   26 +++++++++-----------------
> >  drivers/pci/pcie/aer/aerdrv.c       |    7 +------
> >  drivers/pci/pcie/aer/aerdrv.h       |    8 --------
> >  drivers/pci/pcie/aer/aerdrv_core.c  |   31 ++++---------------------------
> >  4 files changed, 14 insertions(+), 58 deletions(-)
> 
> I'm going to go out on a limb a little bit and apply these to pci/aer for v4.9.
> Please let me know if you trip over any issues.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in the
> body of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html