linux-kernel - Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160917044532.GA5729@Sanchayan-Arch.localdomain>
Date:   Sat, 17 Sep 2016 10:15:32 +0530
From:   maitysanchayan@...il.com
To:     Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios
 property for backlight

Hello Marcel,

On 16-09-16 13:38:54, Marcel Ziswiler wrote:
> On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> > Use enable-gpios property of PWM backlight driver for backlight
> > control. While at it also fix the use of brightness levels required
> > by EDT displays which require inverted PWM's.
> 
> That part I am missing below. Did you forget to include it?

No, actually I missed fixing the commit message. Currently PWM polarity
inversion is not supported and while checking, I kept the brightness
levels as is currently but did not change the commit message.

Will send a v2 and fix this.

Regards,
Sanchayan.

> 
> > Signed-off-by: Sanchayan Maity <maitysanchayan@...il.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 8c67dd8..9100bde 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -49,7 +49,10 @@
> >  
> >  	backlight: backlight {
> >  		compatible = "pwm-backlight";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_gpio_bl_on>;
> >  		pwms = <&pwm4 0 5000000>;
> > +		enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> >  		status = "disabled";
> >  	};
> >  
> > @@ -614,6 +617,12 @@
> >  		>;
> >  	};
> >  
> > +	pinctrl_gpio_bl_on: gpioblon {
> > +		fsl,pins = <
> > +			MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> > +		>;
> > +	};
> > +
> >  	pinctrl_gpio_keys: gpio1io04grp {
> >  		fsl,pins = <
> >  			/* Power button */