linux-kernel - Re: [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160914212303.GC16581@localhost>
Date:   Wed, 14 Sep 2016 16:23:03 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Niklas Cassel <niklas.cassel@...s.com>
Cc:     bhelgaas@...gle.com, jespern@...s.com, linux-arm-kernel@...s.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Niklas Cassel <niklass@...s.com>
Subject: Re: [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port

On Fri, Sep 09, 2016 at 09:45:30AM +0200, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>
> 
> artpec6_add_pcie_port is called from artpec6_pcie_probe.
> artpec6_pcie_probe does not have the __init section marker.
> It is wrong to have the marker on artpec6_add_pcie_port
> when the marker is not on artpec6_pcie_probe.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>

Applied to pci/host-artpec for v4.9, thanks!

> ---
>  drivers/pci/host/pcie-artpec6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
> index 16ba70b7..39bf1a6 100644
> --- a/drivers/pci/host/pcie-artpec6.c
> +++ b/drivers/pci/host/pcie-artpec6.c
> @@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
>  	return dw_handle_msi_irq(pp);
>  }
>  
> -static int __init artpec6_add_pcie_port(struct pcie_port *pp,
> -					struct platform_device *pdev)
> +static int artpec6_add_pcie_port(struct pcie_port *pp,
> +				 struct platform_device *pdev)
>  {
>  	int ret;
>  
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html