linux-kernel - Re: [PATCH 7/8] gpio: wcove: fix implicit assumption module.h is present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Sep 2016 14:04:04 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>,
        Bin Gao <bin.gao@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 7/8] gpio: wcove: fix implicit assumption module.h is present

On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> The Kconfig for this file is:
>
> drivers/gpio/Kconfig:config GPIO_WHISKEY_COVE
> drivers/gpio/Kconfig:   tristate "GPIO support for Whiskey Cove PMIC"
>
> ...but however it does not include module.h -- it in turn gets it from
> another header (gpio/driver.h) and we'd like to replace that with a
> forward delcaration of "struct module;" but if we do, this file will
> fail to compile.
>
> So we fix this first to avoid putting build failures into the bisect
> commit history.
>
> Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>
> Cc: Bin Gao <bin.gao@...el.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied.

Yours,
Linus Walleij