linux-kernel - Re: [PATCH 8/8] gpio: don't include module.h in shared driver header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda1hNBTWcyuVS78kgpUmP2FLU3ZpeG_inendxrQM4mxjQ@mail.gmail.com>
Date:   Thu, 15 Sep 2016 14:05:24 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 8/8] gpio: don't include module.h in shared driver header

On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> Most shared headers in include/linux don't need to know what the
> internals of a struct module are; all they care about is that it
> is a struct and hence they may require a pointer to one.
>
> The advantage in this is that module.h is including a lot of stuff
> itself, and an otherwise empty C file that just contains module.h
> will result in ~750kB from CPP (compared to say 12kB from init.h)
>
> So we have approximately 50 instances of "struct module;" in the
> various include/linux headers already that help us keep module.h
> out of other headers; here we do the same for gpio.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Probably my mistake.
Thanks for tidying this up so nicely!

Patch applied.

Yours,
Linus Walleij