linux-kernel - Re: [PATCH v2] skd: fix assert typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160916130619.GW3075@imgtec.com>
Date:   Fri, 16 Sep 2016 14:06:19 +0100
From:   Eric Engestrom <eric.engestrom@...tec.com>
To:     Jeff Moyer <jmoyer@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Dan Williams <dan.j.williams@...el.com>,
        Ming Lin <ming.l@....samsung.com>,
        Mike Christie <mchristi@...hat.com>
Subject: Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote:
> Eric Engestrom <eric.engestrom@...tec.com> writes:
> 
> > The assert was missing a `!` to become active, but since that would only turn
> > it into a complicated codepath for a pr_err(), let's simply replace it.
> 
> The skd assert macro prints out file and line number, which would have
> been nice to keep.  Sorry I didn't explicitly mention that last time.

I'm not a fan of duplicating code, so if you want to keep the SKD_ASSERT()
format, my suggestion would be to go with the v1 of this patch. It might
end up having an `if` that will always be true, but the compiler will most
likely take care of optimising that away :)

Cheers,
  Eric

> 
> -Jeff
> 
> >
> > CC: Jeff Moyer <jmoyer@...hat.com>
> > Signed-off-by: Eric Engestrom <eric.engestrom@...tec.com>
> > ---
> >  drivers/block/skd_main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> > index 3822eae..c04e92a 100644
> > --- a/drivers/block/skd_main.c
> > +++ b/drivers/block/skd_main.c
> > @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
> >  		break;
> >  
> >  	default:
> > -		SKD_ASSERT("Don't know what to send");
> > +		pr_err("Don't know what to send");
> >  		return;
> >  
> >  	}
> > @@ -2105,7 +2105,7 @@ static void skd_complete_internal(struct skd_device *skdev,
> >  		break;
> >  
> >  	default:
> > -		SKD_ASSERT("we didn't send this");
> > +		pr_err("we didn't send this");
> >  	}
> >  }