linux-kernel - Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2016 10:04:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christian König <christian.koenig@....com>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>, alexander.deucher@....com,
        airlied@...ux.ie, Qingqing.Wang@....com, Monk.Liu@....com,
        JinHuiEric.Huang@....com, Rex.Zhu@....com,
        nils.wallmenius@...il.com, ray.huang@....com, Young.Yang@....com,
        Flora.Cui@....com, Jammy.Zhou@....com, funfunctor@...klore1984.net,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible

On Monday, September 19, 2016 9:59:56 AM CEST Christian König wrote:
> Am 19.09.2016 um 09:34 schrieb Arnd Bergmann:
> > On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote:
> >> We get a few warnings when building kernel with W=1:
> >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes]
> >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes]
> >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes]
> >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes]
> >> ....
> >>
> >> In fact, these functions are only used in the file in which they are
> >> declared and don't need a declaration, but can be made static.
> >> So this patch marks these functions with 'static'.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> >>
> > Hi Baoyou,
> >
> > All your drm/amd patches seem fine to me, but again (as with the nouveau
> > driver patches before), I think it would make more sense to consolidate
> > them, and do a small number of patches such as
> >
> > [PATCH 1/3] drm/amdgpu: add missing includes
> > [PATCH 2/3] drm/amdgpu: remove unused functions
> > [PATCH 3/3] drm/amdgpu: mark symbol static where possible
> >
> > This is all one big driver,
> 
> No it isn't. The different parts are developed by different teams at 
> AMD, so the splitting them up is rather welcome here.
> 
> So please keep your style as it is, at least for the amdgpu driver.

Ok, fair enough. Thanks for the clarification!

	Arnd