linux-kernel - Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160919074345.GA4278@hr-amur2>
Date:   Mon, 19 Sep 2016 15:43:46 +0800
From:   Huang Rui <ray.huang@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <amd-gfx@...ts.freedesktop.org>
CC:     <alexander.deucher@....com>, <christian.koenig@....com>,
        <airlied@...ux.ie>, <Qingqing.Wang@....com>, <Monk.Liu@....com>,
        <JinHuiEric.Huang@....com>, <Rex.Zhu@....com>,
        <nils.wallmenius@...il.com>, <Young.Yang@....com>,
        <Flora.Cui@....com>, <Jammy.Zhou@....com>,
        <funfunctor@...klore1984.net>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <arnd@...db.de>,
        <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where
 possible

Hi Baoyou,

On Mon, Sep 19, 2016 at 03:28:39PM +0800, Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> 

+ amd-gfx mail list.

Thanks to your patch. But powerplay part is refactored recently below, some
functions are already updated. So you might need rebase them. :-)

https://lists.freedesktop.org/archives/amd-gfx/2016-September/002118.html

Thanks,
Rui