lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Sep 2016 12:15:01 +0200 From: Hans Verkuil <hverkuil@...all.nl> To: Stanimir Varbanov <stanimir.varbanov@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org> Cc: Andy Gross <andy.gross@...aro.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Stephen Boyd <sboyd@...eaurora.org>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH v2 4/8] media: vidc: encoder: add video encoder files Many of my review comments for the decoder apply to the encoder as well, so I won't repeat those. On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: > This adds encoder part of the driver plus encoder controls. > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org> > --- > drivers/media/platform/qcom/vidc/venc.c | 1252 +++++++++++++++++++++++++ > drivers/media/platform/qcom/vidc/venc.h | 29 + > drivers/media/platform/qcom/vidc/venc_ctrls.c | 396 ++++++++ > drivers/media/platform/qcom/vidc/venc_ctrls.h | 23 + > 4 files changed, 1700 insertions(+) > create mode 100644 drivers/media/platform/qcom/vidc/venc.c > create mode 100644 drivers/media/platform/qcom/vidc/venc.h > create mode 100644 drivers/media/platform/qcom/vidc/venc_ctrls.c > create mode 100644 drivers/media/platform/qcom/vidc/venc_ctrls.h > > diff --git a/drivers/media/platform/qcom/vidc/venc.c b/drivers/media/platform/qcom/vidc/venc.c > new file mode 100644 > index 000000000000..3b65f851a807 > --- /dev/null > +++ b/drivers/media/platform/qcom/vidc/venc.c > @@ -0,0 +1,1252 @@ <snip> > +static int venc_s_selection(struct file *file, void *fh, > + struct v4l2_selection *s) > +{ > + return -EINVAL; > +} Huh? Either remove this, or implement this correctly. <snip> > +static int venc_subscribe_event(struct v4l2_fh *fh, > + const struct v4l2_event_subscription *sub) > +{ > + switch (sub->type) { > + case V4L2_EVENT_EOS: > + return v4l2_event_subscribe(fh, sub, 2, NULL); > + case V4L2_EVENT_SOURCE_CHANGE: > + return v4l2_src_change_event_subscribe(fh, sub); These two events aren't used in this driver AFAICT, so this can be dropped. Since that leaves just V4L2_EVENT_CTRL this function can be replaced by v4l2_ctrl_subscribe_event(). Regards, Hans > + case V4L2_EVENT_CTRL: > + return v4l2_ctrl_subscribe_event(fh, sub); > + default: > + return -EINVAL; > + } > +}
Powered by blists - more mailing lists