linux-kernel - Re: [PATCH v2 7/8] media: vidc: add Makefiles and Kconfig files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07f0a70-1500-c6aa-b42d-dd97fe8d06cb@xs4all.nl>
Date:   Mon, 19 Sep 2016 12:35:23 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 7/8] media: vidc: add Makefiles and Kconfig files

On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
> Makefile and Kconfig files to build the video codec driver.
> 
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> ---
>  drivers/media/platform/qcom/Kconfig       |  8 ++++++++
>  drivers/media/platform/qcom/Makefile      |  6 ++++++
>  drivers/media/platform/qcom/vidc/Makefile | 15 +++++++++++++++
>  3 files changed, 29 insertions(+)
>  create mode 100644 drivers/media/platform/qcom/Kconfig
>  create mode 100644 drivers/media/platform/qcom/Makefile
>  create mode 100644 drivers/media/platform/qcom/vidc/Makefile
> 
> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
> new file mode 100644
> index 000000000000..4bad5c0f68e4
> --- /dev/null
> +++ b/drivers/media/platform/qcom/Kconfig
> @@ -0,0 +1,8 @@
> +comment "Qualcomm V4L2 drivers"
> +
> +menuconfig QCOM_VIDC
> +        tristate "Qualcomm V4L2 encoder/decoder driver"
> +        depends on ARCH_QCOM && VIDEO_V4L2
> +        depends on IOMMU_DMA
> +        depends on QCOM_VENUS_PIL
> +        select VIDEOBUF2_DMA_SG

If at all possible, please depend on COMPILE_TEST as well!

Also missing: a patch adding an entry to the MAINTAINERS file.

Regards,

	Hans

> diff --git a/drivers/media/platform/qcom/Makefile b/drivers/media/platform/qcom/Makefile
> new file mode 100644
> index 000000000000..150892f6533b
> --- /dev/null
> +++ b/drivers/media/platform/qcom/Makefile
> @@ -0,0 +1,6 @@
> +#
> +# Makefile for the QCOM spcific video device drivers
> +# based on V4L2.
> +#
> +
> +obj-$(CONFIG_QCOM_VIDC)     += vidc/
> diff --git a/drivers/media/platform/qcom/vidc/Makefile b/drivers/media/platform/qcom/vidc/Makefile
> new file mode 100644
> index 000000000000..f8b5f9a438ee
> --- /dev/null
> +++ b/drivers/media/platform/qcom/vidc/Makefile
> @@ -0,0 +1,15 @@
> +# Makefile for Qualcomm vidc driver
> +
> +vidc-objs += \
> +		core.o \
> +		helpers.o \
> +		vdec.o \
> +		vdec_ctrls.o \
> +		venc.o \
> +		venc_ctrls.o \
> +		hfi_venus.o \
> +		hfi_msgs.o \
> +		hfi_cmds.o \
> +		hfi.o \
> +
> +obj-$(CONFIG_QCOM_VIDC) += vidc.o

I recommend renaming the module to qcom-vidc. 'vidc' is too generic.

Regards,

	Hans

>