linux-kernel - Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e87aaaf-9169-0c19-e3ad-21b23babb20e@gmail.com>
Date:   Mon, 19 Sep 2016 23:14:46 +0530
From:   arvind Yadav <arvind.yadav.cs@...il.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     mturquette@...libre.com, a.hajda@...sung.com, lee.jones@...aro.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap



On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote:
> On 09/14, arvind.yadav.cs@...il.com wrote:
>> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np)
>>   	return;
>>   
>>   err:
>> +	if (reg)
> This is always true? Why check?
> I have removed this check. Please review updated patch.
>> +		iounmap(reg);
>>   	if (clk_data)
>>   		kfree(clk_data->clks);
>>   	kfree(clk_data);
>> -- 
>> 1.7.9.5
>>