linux-kernel - Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160914182454.GR7243@codeaurora.org>
Date:   Wed, 14 Sep 2016 11:24:54 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     arvind.yadav.cs@...il.com
Cc:     mturquette@...libre.com, a.hajda@...sung.com, lee.jones@...aro.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

On 09/14, arvind.yadav.cs@...il.com wrote:
> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np)
>  	return;
>  
>  err:
> +	if (reg)

This is always true? Why check?

> +		iounmap(reg);
>  	if (clk_data)
>  		kfree(clk_data->clks);
>  	kfree(clk_data);
> -- 
> 1.7.9.5
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project