linux-kernel - Re: [PATCH 05/61] perf tools: Introduce c2c_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3b6b74e-b55d-3fec-74c5-d476c0b6c9e4@redhat.com>
Date:   Mon, 19 Sep 2016 14:04:10 -0400
From:   Joe Mario <jmario@...hat.com>
To:     Nilay Vaish <nilayvaish@...il.com>, Jiri Olsa <jolsa@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

On 09/19/2016 01:15 PM, Nilay Vaish wrote:
> On 19 September 2016 at 08:09, Jiri Olsa <jolsa@...nel.org> wrote:
>> diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
>> index 7f69bf9d789d..27c6bb5abafb 100644
>> --- a/tools/perf/util/mem-events.h
>> +++ b/tools/perf/util/mem-events.h
>> @@ -2,6 +2,10 @@
>>  #define __PERF_MEM_EVENTS_H
>>
>>  #include <stdbool.h>
>> +#include <stdint.h>
>> +#include <stdio.h>
>> +#include <linux/types.h>
>> +#include "stat.h"
>>
>>  struct perf_mem_event {
>>         bool            record;
>> @@ -33,4 +37,36 @@ int perf_mem__lck_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
>>
>>  int perf_script__meminfo_scnprintf(char *bf, size_t size, struct mem_info *mem_info);
>>
>> +struct c2c_stats {
>> +       int     nr_entries;
>> +
>> +       int     locks;               /* count of 'lock' transactions */
>> +       int     store;               /* count of all stores in trace */
>> +       int     st_uncache;          /* stores to uncacheable address */
>> +       int     st_noadrs;           /* cacheable store with no address */
>
> No address! Why would that happen?

[Resending without the html]

There are a small number of instructions that will trigger a perf mem event and will have no address associated with them.    Three of them include mfence, wrmsr, and rdtsc.    I believe there are at least two more.

>
>
> --
> Nilay
>