linux-kernel - Re: [PATCH] drm/exynos: mark exynos_dp_crtc_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <d9014b26-39fb-ee90-fbdd-dbb0a25350e2@samsung.com>
Date:   Tue, 20 Sep 2016 10:28:20 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, jingoohan1@...il.com,
        inki.dae@...sung.com, jy0922.shim@...sung.com,
        sw0312.kim@...sung.com, kyungmin.park@...sung.com,
        airlied@...ux.ie, kgene@...nel.org, krzk@...nel.org,
        javier@....samsung.com
Cc:     linux-samsung-soc@...r.kernel.org, arnd@...db.de,
        xie.baoyou@....com.cn, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static

On 18.09.2016 15:58, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
--
Regards
Andrzej