linux-kernel - Re: [PATCH] dma-buf/sw_sync: mark sync_timeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO_48GFTkpvKLZghbOtNu=CUB61tZx0q6uC1JPVRMB1rPiSPqA@mail.gmail.com>
Date:   Tue, 20 Sep 2016 18:23:33 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Gustavo Padovan <gustavo@...ovan.org>,
        Baoyou Xie <baoyou.xie@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, xie.baoyou@....com.cn,
        LKML <linux-kernel@...r.kernel.org>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        Linaro MM SIG Mailman List <linaro-mm-sig@...ts.linaro.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

Hi Baoyou,

On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@...ovan.org> wrote:
> 2016-09-18 Baoyou Xie <baoyou.xie@...aro.org>:
>
>> We get 1 warning when building kernel with W=1:
>> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>> ---
>>  drivers/dma-buf/sw_sync.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for finding this.

Thanks for the patch; this doesn't apply to mainline yet, since the
de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree.
CC'ing him.

Greg, would it be possible to please take this via your tree?
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
>
Acked-by: Sumit Semwal <sumit.semwal@...aro.org>

> Gustavo
>

Best regards,
Sumi