linux-kernel - Re: [PATCH] dma-buf/sw_sync: mark sync_timeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920111338.GE13275@joana>
Date:   Tue, 20 Sep 2016 13:13:38 +0200
From:   Gustavo Padovan <gustavo@...ovan.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     sumit.semwal@...aro.org, arnd@...db.de, xie.baoyou@....com.cn,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-18 Baoyou Xie <baoyou.xie@...aro.org>:

> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/dma-buf/sw_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding this.

Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>

Gustavo