linux-kernel - Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get added to the state

Open Source and information security mailing list archives

Message-ID: <CAHbf0-HOLeg6p3K=df3eOk0nuu-FcR63VkMUVUSFKnK4=SJJ5g@mail.gmail.com>
Date:   Tue, 20 Sep 2016 19:45:03 +0100
From:   Mike Lothian <mike@...eburn.co.uk>
To:     Lyude <cpaul@...hat.com>
Cc:     intel-gfx@...ts.freedesktop.org,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Matt Roper <matthew.d.roper@...el.com>,
        Radhakrishna Sripada <radhakrishna.sripada@...el.com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>, stable@...r.kernel.org,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get
 added to the state

Hi

I've bisected back to this commit in the drm-intel-nightly branch

05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
Author: Lyude <cpaul@...hat.com>
Date:   Wed Aug 17 15:55:57 2016 -0400

   drm/i915/skl: Ensure pipes with changed wms get added to the state

   If we're enabling a pipe, we'll need to modify the watermarks on all
   active planes. Since those planes won't be added to the state on
   their own, we need to add them ourselves.

   Signed-off-by: Lyude <cpaul@...hat.com>
   Reviewed-by: Matt Roper <matthew.d.roper@...el.com>
   Cc: stable@...r.kernel.org
   Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
   Cc: Daniel Vetter <daniel.vetter@...el.com>
   Cc: Radhakrishna Sripada <radhakrishna.sripada@...el.com>
   Cc: Hans de Goede <hdegoede@...hat.com>
   Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
   Link: http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com

The symptoms I'm seeing look like tearing at the top of the screen and
it's especially noticeable in Chrome - reverting this commit makes the
issue go away

Let me know if you'd like me to raise a bug

Cheers

Mike

(Re-sending from Gmail - as Inbox doesn't let me send as plain text)

On 17 August 2016 at 20:55, Lyude <cpaul@...hat.com> wrote:
> If we're enabling a pipe, we'll need to modify the watermarks on all
> active planes. Since those planes won't be added to the state on
> their own, we need to add them ourselves.
>
> Signed-off-by: Lyude <cpaul@...hat.com>
> Reviewed-by: Matt Roper <matthew.d.roper@...el.com>
> Cc: stable@...r.kernel.org
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@...el.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@...el.com>
> Cc: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 849f039..a3d24cb 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4117,6 +4117,10 @@ skl_compute_ddb(struct drm_atomic_state *state)
>                 ret = skl_allocate_pipe_ddb(cstate, ddb);
>                 if (ret)
>                         return ret;
> +
> +               ret = drm_atomic_add_affected_planes(state, &intel_crtc->base);
> +               if (ret)
> +                       return ret;
>         }
>
>         return 0;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives