linux-kernel - Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get added to the state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0ee1dc0-ca47-9d0c-6def-a9a0f1921e62@linux.intel.com>
Date:   Wed, 21 Sep 2016 08:56:37 +0200
From:   Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
To:     Mike Lothian <mike@...eburn.co.uk>, Lyude <cpaul@...hat.com>
Cc:     intel-gfx@...ts.freedesktop.org,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Matt Roper <matthew.d.roper@...el.com>,
        Radhakrishna Sripada <radhakrishna.sripada@...el.com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>, stable@...r.kernel.org,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get
 added to the state

Hey,

Op 20-09-16 om 20:45 schreef Mike Lothian:
> Hi
>
> I've bisected back to this commit in the drm-intel-nightly branch
>
> 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
> commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
> Author: Lyude <cpaul@...hat.com>
> Date:   Wed Aug 17 15:55:57 2016 -0400
>
>    drm/i915/skl: Ensure pipes with changed wms get added to the state
>
>    If we're enabling a pipe, we'll need to modify the watermarks on all
>    active planes. Since those planes won't be added to the state on
>    their own, we need to add them ourselves.
>
>    Signed-off-by: Lyude <cpaul@...hat.com>
>    Reviewed-by: Matt Roper <matthew.d.roper@...el.com>
>    Cc: stable@...r.kernel.org
>    Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
>    Cc: Daniel Vetter <daniel.vetter@...el.com>
>    Cc: Radhakrishna Sripada <radhakrishna.sripada@...el.com>
>    Cc: Hans de Goede <hdegoede@...hat.com>
>    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
>    Link: http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com
>
> The symptoms I'm seeing look like tearing at the top of the screen and
> it's especially noticeable in Chrome - reverting this commit makes the
> issue go away
>
> Let me know if you'd like me to raise a bug
Please do so, it's nice to refer to when making a fix for it.

Could you attach the contents of /sys/kernel/debug/dri/0/i915_ddb_info for working and not-working in it?

~Maarten